Populate instance config and data node config during server startup #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djycheng
reviewed
Dec 16, 2025
ambry-api/src/main/java/com/github/ambry/config/ClusterMapConfig.java
Outdated
Show resolved
Hide resolved
| // Pattern to match df -h output lines for Ambry mount points | ||
| // Example: /dev/sdh1 21T 14T 6.5T 68% /mnt/u001/ambrydata | ||
| private static final Pattern DF_PATTERN = Pattern.compile( | ||
| "^(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\S+)\\s+(\\d+)%\\s+(/mnt/u\\d+/ambrydata)$"); |
Contributor
There was a problem hiding this comment.
Can we make this pattern configurable too?
Comment on lines
151
to
155
| /** | ||
| * Collect disk information by running 'df -h' command. | ||
| * @return map of mount point to DiskInfo | ||
| */ | ||
| public static Map<String, DiskInfo> collectDiskInfo() { |
Contributor
There was a problem hiding this comment.
Wondering if we should use some library like OSHI instead of running df -h
Contributor
Author
There was a problem hiding this comment.
hey yes and would be cleaner, but i guess we can keep it simple for the time being? these info will be available in the metadata file very soon
ambry-clustermap/src/main/java/com/github/ambry/clustermap/HelixFactory.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3188 +/- ##
============================================
+ Coverage 64.24% 69.82% +5.57%
- Complexity 10398 12809 +2411
============================================
Files 840 930 +90
Lines 71755 79054 +7299
Branches 8611 9455 +844
============================================
+ Hits 46099 55197 +9098
+ Misses 23004 20916 -2088
- Partials 2652 2941 +289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djycheng
approved these changes
Jan 7, 2026
djycheng
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Done